Brian Slesinsky has posted comments on this change.
Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
......................................................................
Patch Set 1:
(1 comment)
More to come but I'll start with this.
....................................................
File user/src/com/google/gwt/logging/impl/StackTracePrintStream.java
Line 25: public class StackTracePrintStream extends PrintStream {
This class is a bit confusing because it extends PrintStream but it's not a
general-purpose PrintStream. It doesn't seem like a great API. Perhaps
instead, we could stop calling Throwable.printStackTrace() and instead
write a different utility method:
void appendStackTrace(Throwable t, StringBuilder out);
The implementation can use getStackTrace() and avoid using a PrintStream at
all.
--
To view, visit https://gwt-review.googlesource.com/2310
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeee26a9b36cbe40bd1cf0942da8fae39179e985
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
