Goktug Gokdogan has posted comments on this change.
Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
......................................................................
Patch Set 1:
(8 comments)
....................................................
File user/src/com/google/gwt/logging/impl/FormatterImpl.java
Line 48: * @deprecated Use {@link
Throwable#printStackTrace(PrintStream)} instead.
Done
....................................................
File user/src/com/google/gwt/logging/impl/StackTracePrintStream.java
Line 25: public class StackTracePrintStream extends PrintStream {
Thanks, I liked the idea of explicit stating which methods that all data
will flow through and are meant to be overridden. I added those two methods
and marked the rest as final. Also documented them in the class javadoc. It
looks better now.
....................................................
File user/src/com/google/gwt/logging/server/JsonLogRecordServerUtil.java
Line 80: return new Throwable(cause) {
Done
....................................................
File
user/src/com/google/gwt/user/client/rpc/core/java/util/logging/LogRecord_CustomFieldSerializer.java
Line 36: SerializableThrowable thrown = (SerializableThrowable)
reader.readObject();
With protocol mismatch do you mean the case where client and server
versions doesn't match?
In that case how the rest of the system will work and why would we get a
ClassCastException? Other serialization/deserialization related to logging
rpc will also fail right?
Perhaps I didn't get what you mean.
....................................................
File
user/src/com/google/gwt/user/server/rpc/core/java/util/logging/LogRecord_ServerCustomFieldSerializer.java
Line 35
I have no other information then the related change; which says:
"Adds pre-deserialization type checking for values in GWT RPC messages.
The server will now avoid deserializing types that mismatch the RPC
method that is being invoked, reducing the chance that an erroneous
message will cause uncaught deserialization errors on the server."
It looks like it is for better error messaging. I think LogRecord should
not be sent from server to client in the first place. Anyway, I can revert
my change if you don't feel comfortable.
....................................................
File user/test/com/google/gwt/logging/LoggingTest.gwt.xml
Line 17: <inherits name='com.google.gwt.junit.JUnit'/>
My bad. Removed.
....................................................
File user/test/com/google/gwt/logging/client/StackTracePrintStreamTest.java
Line 31: StringBuilder stackTraceBuilder = new StringBuilder();
Done
Line 34: StringBuilder expectedStackTraceBuilder = new StringBuilder();
Done
--
To view, visit https://gwt-review.googlesource.com/2310
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeee26a9b36cbe40bd1cf0942da8fae39179e985
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
