Thomas Broyer has posted comments on this change.
Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
......................................................................
Patch Set 1:
(2 comments)
....................................................
File user/src/com/google/gwt/logging/impl/FormatterImpl.java
Line 48: * @deprecated Use {@link
Throwable#printStackTrace(PrintStream)} instead.
Maybe @link to the StackTracePrintStream as well?
....................................................
File user/test/com/google/gwt/logging/LoggingTest.gwt.xml
Line 17: <inherits name='com.google.gwt.junit.JUnit'/>
I'm curious why you need this LoggingTest module: won't JUnitShell
synthesize a module that inherits com.google.gwt.junit.JUnit and the module
returned by GWTTEstCase#getModuleName() ? (so
returning "com.google.gwt.logging.Logging" from
StackTracePrintStreamTest#getModuleName() would be equivalent)
--
To view, visit https://gwt-review.googlesource.com/2310
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeee26a9b36cbe40bd1cf0942da8fae39179e985
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
