Goktug Gokdogan has posted comments on this change.
Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
user/src/com/google/gwt/user/client/rpc/core/java/util/logging/LogRecord_CustomFieldSerializer.java
Line 36: SerializableThrowable thrown = (SerializableThrowable)
reader.readObject();
I thought GWT-RPC was generating a hash/signature so that this method will
not be called if client is stale.
Even if it is called, data stream will be incorrect and previous calls to
readString / readLong etc will very likely not work properly before
reaching readObject call.
If readObject call is reached somehow, then it will very likely fail if
reading the object instead of returning an instance from another class.
So I don't think instanceof will help, but perhaps we shouldn't be using
GWT-RPC for logging in the first place.
--
To view, visit https://gwt-review.googlesource.com/2310
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeee26a9b36cbe40bd1cf0942da8fae39179e985
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
