Goktug Gokdogan has posted comments on this change.
Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File user/src/com/google/gwt/logging/impl/StackTracePrintStream.java
Line 25: public class StackTracePrintStream extends PrintStream {
Throwable#printStackTrace is already the established way of printing
formatted stack traces in java and ideally we should not replicate that (on
dev mode this provides even fancier printing by detecting duplicate stack
trace items).
Also this approach works well with different formatting styles to handle
new lines and tabs.
Also note that, this is not a public API so it didn't make sense to me to
implement the full PrintStream API for internal use case and I put some
tests in place that will fail if the contract changes.
--
To view, visit https://gwt-review.googlesource.com/2310
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeee26a9b36cbe40bd1cf0942da8fae39179e985
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
