Roberto Lublinerman has uploaded a new patch set (#2).
Change subject: Allow @UIHandler annotated methods to be private.
......................................................................
Allow @UIHandler annotated methods to be private.
Even though @UIHandler annotated methods were not allowed to
be private, a bug in JDT 3.4 was dropping the private modifier from
methods that have annotations in parameters and this was causing UIHandler
to work with private methods.
For example it was allowing:
@UiHandler("event")
private void event(@Nullable Event event) { ...}
The JDT bug is fixed in JDT 3.8, thus migrating to JDT 3.8 causes
breakage in many projects that unknowingly depend on the bug being present.
Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f
Review-Link: https://gwt-review.googlesource.com/#/c/2450/
---
M user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java
M user/test/com/google/gwt/uibinder/test/client/HandlerDemo.java
2 files changed, 13 insertions(+), 11 deletions(-)
--
To view, visit https://gwt-review.googlesource.com/2450
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
