Brian Slesinsky has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
......................................................................
Patch Set 2:
The surprise comes from violating expectations. I would expect all callers
to a private method to be in the same file. And tools assume this too; for
example IDEA will mark a method as unused if it private and there are no
uses in the same file. So, I might delete the method, then recompile and
discover that it is used after all. And I wonder if other tools might be
fooled, for example someday there might be a tool to automatically remove
all private unused methods in your code, and such tools would need to be
modified to look for the UIHandler annotation.
This isn't a big deal today since there is no such tool and there is an
annotation, which seems like a sufficient warning to the reader. But I do
think it's slightly simpler and more future-proof if "private" means what
the Java specification says, not "private except for these special cases
that you have to remember."
--
To view, visit https://gwt-review.googlesource.com/2450
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
