Matthew Dempsky has posted comments on this change.

Change subject: Allow @UIHandler annotated methods to be private.
......................................................................


Patch Set 2:

Current behavior (forcing it to be package-visible) I think is just an incident of how generators usually work.

It's also the behavior for how annotation processing generated code works; e.g., if you use Dagger, your @Provides methods need to be package-visible too.

I think it's least surprising to require the methods to package-visible, because it'll be consistent with requirements that Java programmers will/may already be familiar with.

--
To view, visit https://gwt-review.googlesource.com/2450
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to