Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
......................................................................
Patch Set 2:
If somebody thinks that a field/method needs to be package visible for
uibinder then they will do that and it will work as expected without a
surprise.
Things usually cause surprises when they don't work, not when they do work
=)
About common practice; javax.inject says it should work with privates and
traditional java (Spring, Guice) all work with privates. Also note that
Dagger is trying minimize reflection for performance reasons and it might
be the only reason for the exclusion.
Putting everything aside, most importantly from a practical perspective,
exposing your fields in your class is pretty annoying to make UiBinder work
=)
--
To view, visit https://gwt-review.googlesource.com/2450
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
