Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
......................................................................
Patch Set 2:
Actually, I encouraged this solution so I will try to answer.
I think enabling private methods with @UiHandler (and later with UiField)
is a reasonable feature not just a workaround.
While using UiBinder, many times I hoped that was how it was behaving
originally - especially with UiFields.
If there were no UiHandler magic then we would have created an anonymous
class to delegate to a private handler method instead of exposing the
handler method outside. Current behavior (forcing it to be package-visible)
I think is just an incident of how generators usually work.
IIRC, this new behavior is also consistent with @Inject in google-gin which
again makes sense to me.
--
To view, visit https://gwt-review.googlesource.com/2450
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
