Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
......................................................................
Patch Set 2:
Actually we discussed this internally and we have an agreement on our side
to add the support as a feature.
I'm keeping the thread up to date and would like to hear if you still have
any concerns:
1. In UiBinder, the xml is more like a part of the view class itself that
is extracted out to make it more declarative and it can be considered as
internal. From that point of view, we are not really violating the
semantics of the private (at least as not much as in @inject case.)
2. UiFields are nearly always only used in the class itself. When we don't
declare them private, then it is difficult to discover if they are used or
not as the IDE will not point that out.
3. Tools are already aware of the fact that methods with annotations are
usually used by magic and provides easy ways to configure as this is kind
of a common practice in java.
--
To view, visit https://gwt-review.googlesource.com/2450
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03c7787ced5a339a74d49ec917d48edebd5dbb8f
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
