http://bugs.gpodder.org/show_bug.cgi?id=69
--- Comment #4 from Thomas Perl <[EMAIL PROTECTED]> 2008-03-25 09:06:21 --- On second thought, yes you are right: We should probably leave the checkbox in. It's not so much space that's being used by the check box, and it makes it visually very clear if the feature is enabled or not. For the thread synchronization problem: If you aren't working directly on the Gtk objects, you shouldn't have to synchronize access to the configuration variables (the gl.config.* variables). Only the UI code is writing this value and the other code is reading it. From what I see in src/gpodder/download.py, you should be safe simply replacing "self.limit_rate" and "self.limit_rate_value" with "gl.config.limit_rate" and "gl.config.limit_rate_value". The only problem I see is that when rate limiting is switched off, half of the file gets downloaded at some high speed and then rate limiting is switched on, gPodder would stall the transfer for a long time. We should probably make these calculations more short-term, i.e. only look at the last 5% of the file downloaded and calculate the speed from there. -- Configure bugmail: http://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
