http://bugs.gpodder.org/show_bug.cgi?id=69
--- Comment #20 from Paul Rudkin <[EMAIL PROTECTED]> 2008-04-15 21:35:14 --- Hi Thomas, yest that was one of the changes. The only reason I removed this was so that we could get down to rates lower that 5Kb/s. Having the if statement that in there means that the lowest speed is more of a function of downstream bandwidth over the 5 blocks (approx 40K). I ran a very brief test downloading 2 podcasts and did not notice any major CPU usage change at all. I would think the calculation would be very quick to perform for each downloaded block. Do you recall exactly the symptoms which caused you to add this statement? I have gone through the SVN revisions and it looks like it has been there since download.py was committed, however changes made at r436 seem to relate to CPU usage which are still present in the code, though these related to actual GUI update rather than speed calculation. If you feel more comfortable perhaps we should add the statement back in until I can do further testing. If that is the case then we should also set the minimum rate to be 5Kb/s instead of 0.5Kb/s. Would you like me to create another patch? If you want to add the line yourself then it should be added to attachment #41. -- Configure bugmail: http://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
