https://bugs.gpodder.org/show_bug.cgi?id=60
--- Comment #49 from Thomas Perl <[email protected]> 2009-12-15 19:22:06 GMT --- (In reply to comment #48) > I implemented the aggregate channel in the simplest way I could think of. It > works, but probably needs some further tinkering. Any improvements or feedback > are welcome. Thanks! Some feedback after looking through the patch: Instead of writing if model.get_value(iter, self.C_SEPARATOR) is True: you can simply write if model.get_value(iter, self.C_SEPARATOR): (see http://www.python.org/dev/peps/pep-0008/ on "Don't compare boolean values to True or False") The class "PodcastChannelProxy" should be in src/gpodder/gtkui/model.py (because this way, you don't need to "import gtk" in the __init__ method. Is there a reason for writing "return sum(episodes, [])" in PodcastChannelProxy's "get_all_episodes" function? The list comprehension will return an empty list in case no episodes are found. Other than these issues, the patch already looks good. -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
