https://bugs.gpodder.org/show_bug.cgi?id=60
Thomas Perl <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #384 is|0 |1 obsolete| | --- Comment #51 from Thomas Perl <[email protected]> 2009-12-16 13:53:31 GMT --- Created an attachment (id=385) --> (https://bugs.gpodder.org/attachment.cgi?id=385) Updated patch (2009-12-16) (In reply to comment #50) > Thanks for the feedback. I fixed the pep-0008 violation and moved the proxy > class to src/gpodder/gtkui/model.py. The class now inherits directly from > object, so it no longer has any relation to the PodcastModelObject class. Great, thanks! > I also added comment explaining the intent with "return sum(episodes, [])". The comment explains it, thanks :) I've updated the patch and added some features/fixes: * Disable and enable the view with "podcast_list_view_all" * The statistics on the proxy now reflect the correct count for all episodes * Removed the cover art (for now..) * gettextized the strings in the proxy object ("All episodes", ...) * Calculate the save_dir_size (for the tooltip) * Make row_separator_func a classmethod, as it's functionality is stateless * Use a generator for get_all_episodes() instead of building up a list It's still not as fast as it can be, but the patch is in good shape already. With a little bit of work, we could make it ready for the next release (maybe disabled by default, but at least advanced users can easily enable this feature then). -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
