https://bugs.gpodder.org/show_bug.cgi?id=60
Janne Makela <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #383 is|0 |1 obsolete| | --- Comment #50 from Janne Makela <[email protected]> 2009-12-15 22:55:37 GMT --- Created an attachment (id=384) --> (https://bugs.gpodder.org/attachment.cgi?id=384) Patch cleaned up according to the feedback Thanks for the feedback. I fixed the pep-0008 violation and moved the proxy class to src/gpodder/gtkui/model.py. The class now inherits directly from object, so it no longer has any relation to the PodcastModelObject class. I also added comment explaining the intent with "return sum(episodes, [])". It's just a simple way to flatten the list of lists that results from the list comprehension. It's a trick (see http://kogs-www.informatik.uni-hamburg.de/~meine/python_tricks), but as far as I know it works reliably in this case. And alternative solutions are not so neat. However, if that line terrifies you I can do it differently too:) -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
