[
https://issues.apache.org/jira/browse/HDFS-12069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073166#comment-16073166
]
Mukul Kumar Singh commented on HDFS-12069:
------------------------------------------
Thanks for working on this [~cheersyang], the patch looks good I have some
minor comments
1) Can the config changes in OzoneConfigKeys.java be move to SCMConfig keys or
another common location ?
This is needed so that the abstracted MetadataStore can also be used by CBlock
and other related subsystems.
2) LevelDBStore.java:81, Can we log the DB Path and the options if open fails ?
3) LevelDBStore.java:261, I am not really sure about this, but I feel that if
there is only one operation inside the batch then the operation can be called
directly without creating a batch. This will help reduce the batching overhead.
> Ozone: Create a general abstraction for metadata store
> ------------------------------------------------------
>
> Key: HDFS-12069
> URL: https://issues.apache.org/jira/browse/HDFS-12069
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Attachments: HDFS-12069-HDFS-7240.001.patch,
> HDFS-12069-HDFS-7240.002.patch, HDFS-12069-HDFS-7240.003.patch
>
>
> Create a general abstraction for metadata store so that we can plug other key
> value store to host ozone metadata. Currently only levelDB is implemented, we
> want to support RocksDB as it provides more production ready features.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
