[
https://issues.apache.org/jira/browse/HDFS-12069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077063#comment-16077063
]
Xiaoyu Yao commented on HDFS-12069:
-----------------------------------
Thanks [~cheersyang] for working on this. Patch v5 looks pretty good to me. Few
comments below.
1. KeyManagerImpl.java
Line 34/89/114/148/182: Should we change the KeyUtils.getDB here to use the
abstracted interface instead of the hardcoded LevelDBStore?
Similar question to SCM components that are hard coded to LevelDBStore today?
Should we switch that to use the MetadataStore interface like we've done here
for some of the ops in MetadataManagerImpl for KSM?
2. MetadataManagerImpl.java
Line 213/232: should we update to use the MetadataStore interface methods like
writeBatch()?
3. OzoneConfigKeys.java
Line 67: NIT: can we define the const as "LevelDB" to be consistent with the
official name.
Line 69: NIT: can we define the const as "RocksDB" to be consistent with the
official name.
4. ozone-default.xml
Line 570: NIT: "LevelDB"
Line 575: NIT: "LevelDB" and "RocksDB"
5. TestMetadataStore.java
Line 65-66: NIT: remove the unused comments.
> Ozone: Create a general abstraction for metadata store
> ------------------------------------------------------
>
> Key: HDFS-12069
> URL: https://issues.apache.org/jira/browse/HDFS-12069
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Attachments: HDFS-12069-HDFS-7240.001.patch,
> HDFS-12069-HDFS-7240.002.patch, HDFS-12069-HDFS-7240.003.patch,
> HDFS-12069-HDFS-7240.004.patch, HDFS-12069-HDFS-7240.005.patch
>
>
> Create a general abstraction for metadata store so that we can plug other key
> value store to host ozone metadata. Currently only levelDB is implemented, we
> want to support RocksDB as it provides more production ready features.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
