[
https://issues.apache.org/jira/browse/HDFS-12069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076299#comment-16076299
]
Weiwei Yang commented on HDFS-12069:
------------------------------------
Hi [~msingh]
Thanks for helping to review this.
bq. Can the config changes in OzoneConfigKeys.java be move to SCMConfig keys or
another common location ?
The properties I intend to add are not just for SCM, so it is inappropriate to
move them to SCMConfigKeys. If cblock classes have no access to ozone package
and you think it's necessary to share this to cblocks, we need to think another
way around, I would love to know your suggestion.
bq. LevelDBStore.java:81, Can we log the DB Path and the options if open fails ?
I just removed that line, I don't think it will ever get a null value.
JniDBFactory.factory.open always returns a DB instance unless there is some
exception creating it. So either it throws exception, or it is a non-null
value. So I removed that line.
bq. but I feel that if there is only one operation inside the batch then the
operation can be called directly without creating a batch.
The batch operation is only used when there is a batch of atomic operations, so
we don't really expect a single operation here.
Thank you
> Ozone: Create a general abstraction for metadata store
> ------------------------------------------------------
>
> Key: HDFS-12069
> URL: https://issues.apache.org/jira/browse/HDFS-12069
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Attachments: HDFS-12069-HDFS-7240.001.patch,
> HDFS-12069-HDFS-7240.002.patch, HDFS-12069-HDFS-7240.003.patch,
> HDFS-12069-HDFS-7240.004.patch
>
>
> Create a general abstraction for metadata store so that we can plug other key
> value store to host ozone metadata. Currently only levelDB is implemented, we
> want to support RocksDB as it provides more production ready features.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
