[ 
https://issues.apache.org/jira/browse/HDFS-12069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077472#comment-16077472
 ] 

Weiwei Yang commented on HDFS-12069:
------------------------------------

Hi [~xyao]

Thanks for helping to review this, please see my comments below

bq. Should we change the KeyUtils.getDB here to use the abstracted interface 
instead of the hardcoded LevelDBStore? ... Similar question to SCM components

I was trying not to fix all LevelDBStore in this patch, that will make this 
patch a very big one. But I actually have done some more work so I can add them 
in one patch if you like. I was thinking that is not easy for review so I split 
the work to 3 steps: 1) create general abstraction, the interface 2) Replace 
existing levelDB references 3) implement rocksDB; I can combine 1 & 2 in this 
JIRA, if you prefer.

I will fix rest of issues in the comments.

Thank you!

> Ozone: Create a general abstraction for metadata store
> ------------------------------------------------------
>
>                 Key: HDFS-12069
>                 URL: https://issues.apache.org/jira/browse/HDFS-12069
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: HDFS-12069-HDFS-7240.001.patch, 
> HDFS-12069-HDFS-7240.002.patch, HDFS-12069-HDFS-7240.003.patch, 
> HDFS-12069-HDFS-7240.004.patch, HDFS-12069-HDFS-7240.005.patch
>
>
> Create a general abstraction for metadata store so that we can plug other key 
> value store to host ozone metadata. Currently only levelDB is implemented, we 
> want to support RocksDB as it provides more production ready features.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to