[ 
https://issues.apache.org/jira/browse/HDFS-14258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763022#comment-16763022
 ] 

Íñigo Goiri commented on HDFS-14258:
------------------------------------

{quote}
In regards to a dead-lock, the noPeers Condition is associated with the lock 
object. When waiting on that condition, the thread gives up the lock and only 
becomes active once the Condition has been signaled and has re-acquired the 
lock.
{quote}
As I said, fancy stuff. Leveraging the sync in Java makes the code much 
cleaner. Let's go for it.

Regarding code coverage, we might be able to tune the parameters to make it 
faster than 30 seconds.
Actually, this sounds like the kind of thing that should be configurable 
actually.
One could even get the old behavior tuning this parameter.

I have to go through the tests but it wouldn't hurt to add some concurrency 
test here.

> Introduce Java Concurrent Package To DataXceiverServer Class
> ------------------------------------------------------------
>
>                 Key: HDFS-14258
>                 URL: https://issues.apache.org/jira/browse/HDFS-14258
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 3.2.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HDFS-14258.1.patch, HDFS-14258.2.patch, 
> HDFS-14258.3.patch
>
>
> * Use Java concurrent package to replace current facilities in 
> {{DataXceiverServer}}.
> * A little bit of extra clean up



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to