[
https://issues.apache.org/jira/browse/HDFS-14258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766322#comment-16766322
]
BELUGA BEHR commented on HDFS-14258:
------------------------------------
[~elgoiri]
{quote}
Just one minor comment: you added some javadoc comments in the middle to mark
the different phases, we should make them regular comments.
{quote}
I am sorry. I do not understand this comment. Are you referring to {{Simulate
grabbing 2 threads}} ?? If so, this is the appropriate comment format.
I think it is more clear calling {{Math.abs}} than to introduce a magic number
and assuming that everyone understands basic math :) I'm not sure what about
this you do not like.
I hope you will consider accepting the latest patch. I very much appreciate
all your feedback and time.
> Introduce Java Concurrent Package To DataXceiverServer Class
> ------------------------------------------------------------
>
> Key: HDFS-14258
> URL: https://issues.apache.org/jira/browse/HDFS-14258
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HDFS-14258.1.patch, HDFS-14258.2.patch,
> HDFS-14258.3.patch, HDFS-14258.4.patch, HDFS-14258.5.patch,
> HDFS-14258.6.patch, HDFS-14258.7.patch
>
>
> * Use Java concurrent package to replace current facilities in
> {{DataXceiverServer}}.
> * A little bit of extra clean up
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
