[
https://issues.apache.org/jira/browse/HDFS-14258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765291#comment-16765291
]
Íñigo Goiri commented on HDFS-14258:
------------------------------------
The checkstyle should be fine; the switch is all messed up.
My main concern at this point is the change of behavior.
Right now we have {{DEFAULT_RECONFIGURE_WAIT}} (which should have a comment
saying is seconds).
I think we can achieve the old behavior by setting it to a very large number.
Actually we should handle special values like 0 or MAX_VALUE to achieve special
behaviors.
I'm still on the fence with not making this a configuration; in any case, this
should be marked as changing behavior.
As a minor nit, we could do {{waitAllPeers(2, TimeUnit.SECONDS);}}.
> Introduce Java Concurrent Package To DataXceiverServer Class
> ------------------------------------------------------------
>
> Key: HDFS-14258
> URL: https://issues.apache.org/jira/browse/HDFS-14258
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HDFS-14258.1.patch, HDFS-14258.2.patch,
> HDFS-14258.3.patch, HDFS-14258.4.patch, HDFS-14258.5.patch
>
>
> * Use Java concurrent package to replace current facilities in
> {{DataXceiverServer}}.
> * A little bit of extra clean up
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
