[ 
https://issues.apache.org/jira/browse/HDFS-14343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786929#comment-16786929
 ] 

Íñigo Goiri commented on HDFS-14343:
------------------------------------

Thanks [~ayushtkn] for the patch.
I need to take a closer look but I think we should add a unit test for 
isMultiDestDirectory().
We should cover:
* Files
* Directories
* Non existing
* Weird permissions like a directories we don't have access to. 
* Others like links? 

> RBF: Fix renaming folders spread across multiple subclusters
> ------------------------------------------------------------
>
>                 Key: HDFS-14343
>                 URL: https://issues.apache.org/jira/browse/HDFS-14343
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-14343-HDFS-13891-01.patch
>
>
> The {{RouterClientProtocol#rename()}} function assumes that we are renaming 
> files and only renames one of them (i.e., {{invokeSequential()}}). In the 
> case of folders which are in all subclusters (e.g., HASH_ALL) we should 
> rename all locations (i.e., {{invokeAll()}}).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to