[
https://issues.apache.org/jira/browse/HDFS-14343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787479#comment-16787479
]
Íñigo Goiri commented on HDFS-14343:
------------------------------------
Thanks [~ayushtkn] for [^HDFS-14343-HDFS-13891-03.patch].
* I think we can make {{isMultiDestDirectory()}} to be package visible (no
modified) instead of public.
* Let's just make the log in line 1887 a debug log, this is a normal code path,
no need for warning.
* Don't know what to do with the {{UnresolvedPathException}}, is it worth a
warning or debug is enough?
* Instead of log an throw for the IOException, let's just let it go throw
without catching and logging. The receiver of the exception will log if needed.
* The unit tests looks good. We may want to define some of the variables when
we need them. For example, dst2 and nnDst2 can be defined in line 532.
* As {{testRenameMultipleDestDirectories()}} and
{{verifyRenameOnMultiDestDirectories()}} are directly connected, we may want to
do {{testIsMultiDestDir()}} before both.
Other than this minor comments, I think this is pretty much ready.
> RBF: Fix renaming folders spread across multiple subclusters
> ------------------------------------------------------------
>
> Key: HDFS-14343
> URL: https://issues.apache.org/jira/browse/HDFS-14343
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-14343-HDFS-13891-01.patch,
> HDFS-14343-HDFS-13891-02.patch, HDFS-14343-HDFS-13891-03.patch
>
>
> The {{RouterClientProtocol#rename()}} function assumes that we are renaming
> files and only renames one of them (i.e., {{invokeSequential()}}). In the
> case of folders which are in all subclusters (e.g., HASH_ALL) we should
> rename all locations (i.e., {{invokeAll()}}).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
