[ 
https://issues.apache.org/jira/browse/HDFS-14343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787083#comment-16787083
 ] 

Ayush Saxena commented on HDFS-14343:
-------------------------------------

For a file that is not present. The file status returned is null rather than 
giving a FileNotFoundException. So we can have a null check at 
{{RouterClientProtocol#1880}}

Regarding the symlink. I guess getFileInfo isn't behaving as we want. For 
symLink instead returning the status. It throws back exception telling it is 
symlink, It has a check for symLink at namenode side. So I guess for this we 
need to catch exception. If I am  ain't missing something.
{noformat}
org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.hdfs.protocol.UnresolvedPathException):
 /tmp/dir/file
    at 
org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkNotSymlink(FSPermissionChecker.java:657)
    at 
org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkTraverse(FSPermissionChecker.java:616)
    at 
org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkTraverse(FSDirectory.java:1823)
    at 
org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkTraverse(FSDirectory.java:1841)
    at 
org.apache.hadoop.hdfs.server.namenode.FSDirectory.resolvePath(FSDirectory.java:681)
    at 
org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getFileInfo(FSDirStatAndListingOp.java:109)
    at 
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getFileInfo(FSNamesystem.java:3205)
    at 
org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getFileInfo(NameNodeRpcServer.java:1197){noformat}
{quote}For example verify that the files are in both time.
{quote}
I didn't catch this. Do you mean checking if there is file in all subclusters? 
If so, if we invoke RPC at all subcluster. we would land back to the stage 
worse than directly calling invokeAll after checking isPathAll() in terms of 
RPC calls.(since now we are having an overhead of calculation too).
 
Pls correct if going somewhere wrong.

> RBF: Fix renaming folders spread across multiple subclusters
> ------------------------------------------------------------
>
>                 Key: HDFS-14343
>                 URL: https://issues.apache.org/jira/browse/HDFS-14343
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-14343-HDFS-13891-01.patch, 
> HDFS-14343-HDFS-13891-02.patch
>
>
> The {{RouterClientProtocol#rename()}} function assumes that we are renaming 
> files and only renames one of them (i.e., {{invokeSequential()}}). In the 
> case of folders which are in all subclusters (e.g., HASH_ALL) we should 
> rename all locations (i.e., {{invokeAll()}}).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to