[ 
https://issues.apache.org/jira/browse/HDFS-14343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787029#comment-16787029
 ] 

Íñigo Goiri commented on HDFS-14343:
------------------------------------

* I guess {{TestRouterRPCMultipleDestinationMountTableResolver#455}} should be 
a file path (there is two nodir).
* What about links to directories?
* Is there a chance {{RouterClientProtocol#1880}} can return null?
* We may want to capture the expected exception (FileNotFound I guess) in 
{{RouterClientProtocol#1884}}. Then we can capture the general exception but 
log it as an error. I think we may have other exceptions like 
NamenodeNotAvailable and other RBF exceptions too. Actually, we may want to let 
those surface.

> RBF: Fix renaming folders spread across multiple subclusters
> ------------------------------------------------------------
>
>                 Key: HDFS-14343
>                 URL: https://issues.apache.org/jira/browse/HDFS-14343
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-14343-HDFS-13891-01.patch, 
> HDFS-14343-HDFS-13891-02.patch
>
>
> The {{RouterClientProtocol#rename()}} function assumes that we are renaming 
> files and only renames one of them (i.e., {{invokeSequential()}}). In the 
> case of folders which are in all subclusters (e.g., HASH_ALL) we should 
> rename all locations (i.e., {{invokeAll()}}).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to