[
https://issues.apache.org/jira/browse/HDFS-14343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786964#comment-16786964
]
Íñigo Goiri commented on HDFS-14343:
------------------------------------
I went a little deeper and in addition to the previous comments:
* Restrict the visibility of {{isMultiDestDirectory()}} and mark it as
VisibleForTesting for the tests I mentioned before.
* Handle error cases better in {{isMultiDestDirectory()}} like file not found,
null outputs etc.
* For the test I would put all the variations together in a single test
function.
* We should test some corner cases like one of the namespaces not having the
source folder and one of the destinations already existing.
> RBF: Fix renaming folders spread across multiple subclusters
> ------------------------------------------------------------
>
> Key: HDFS-14343
> URL: https://issues.apache.org/jira/browse/HDFS-14343
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-14343-HDFS-13891-01.patch
>
>
> The {{RouterClientProtocol#rename()}} function assumes that we are renaming
> files and only renames one of them (i.e., {{invokeSequential()}}). In the
> case of folders which are in all subclusters (e.g., HASH_ALL) we should
> rename all locations (i.e., {{invokeAll()}}).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
