[
https://issues.apache.org/jira/browse/HDFS-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059416#comment-17059416
]
Íñigo Goiri commented on HDFS-15221:
------------------------------------
Thanks [~hadoop_yangyun] for the update.
Much easier to follow now.
* Should we do the new key on Commons? These changes only target the DN so I
would restrict it to HDFS.
* Add a javadoc to getEffectiveFileSystem(), mostly to give an idea why we use
DF.
* The new block in instantiateDataNode() should probably go into its own
function and use the output in an if to decide if we do
locations.add(location). The log message can go in the else.
* Shouldn't the var in the test be "[DISK]/dir1" with capitals?
> Add checking of effective filesystem during initializing storage locations
> --------------------------------------------------------------------------
>
> Key: HDFS-15221
> URL: https://issues.apache.org/jira/browse/HDFS-15221
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Yang Yun
> Assignee: Yang Yun
> Priority: Minor
> Attachments: HDFS-15221-002.patch, HDFS-15221-003.patch,
> HDFS-15221.patch
>
>
> We sometimes mount different disks for different storage types as the storage
> location. It's important to check the volume is mounted rightly before
> initializing storage locations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
