[
https://issues.apache.org/jira/browse/HDFS-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060421#comment-17060421
]
Íñigo Goiri commented on HDFS-15221:
------------------------------------
Thanks [~hadoop_yangyun] for the update.
Minor comments:
* Move the javadoc from 2814-2819 to the function.
* Instead of using exceptions (more expensive and should be exceptions not
regular code path), let's return false and check for that.
* Let's not add so many breaklines in the javadocs between param, return, etc.
* Anyway we can document this feature?
Other than that, this looks pretty much ready to go.
> Add checking of effective filesystem during initializing storage locations
> --------------------------------------------------------------------------
>
> Key: HDFS-15221
> URL: https://issues.apache.org/jira/browse/HDFS-15221
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Yang Yun
> Assignee: Yang Yun
> Priority: Minor
> Attachments: HDFS-15221-002.patch, HDFS-15221-003.patch,
> HDFS-15221-004.patch, HDFS-15221-005.patch, HDFS-15221.patch
>
>
> We sometimes mount different disks for different storage types as the storage
> location. It's important to check the volume is mounted rightly before
> initializing storage locations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
