[ 
https://issues.apache.org/jira/browse/HIVE-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784310#action_12784310
 ] 

Ning Zhang commented on HIVE-924:
---------------------------------

Hi Carl,  sorry that we have not got enough cycles to review this patch in 
time. We will do it soon.. Before doing that, there are some conflicts when 
applying this patch to the latest revision. Can you update it to the latest 
revision? One general questions based on your description: currently 
SemanticAnalyzer handles query, DML and DDL. Is there any reason that you only 
split SemanticAnalyzer to DMLSemanticAnalyzer, not the other two?


> Extract LogicalPlan and PhysicalPlan classes from SemanticAnalysis class
> ------------------------------------------------------------------------
>
>                 Key: HIVE-924
>                 URL: https://issues.apache.org/jira/browse/HIVE-924
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Carl Steinbach
>         Attachments: HIVE-924.patch
>
>
> Currently the SemanticAnalyzer class handles semantic analysis, as well as 
> logical plan generation and physical plan generation. I think it would be 
> beneficial to extract distinct LogicalPlan and PhysicalPlan classes from the 
> SemanticAnalyzer, and have the query processing phase be coordinated by a 
> QueryCompiler class that would be responsible for triggering the parsing, 
> semantic analysis, logical plan generation, optimization, and physical plan 
> generation phases. This proposed reorganization of components would help to 
> isolate the state of each phase, and would also bring the source into closer 
> alignment with the description of the query compiler in the Hive design 
> document on the wiki.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to