[ https://issues.apache.org/jira/browse/HIVE-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784455#action_12784455 ]
Carl Steinbach commented on HIVE-924: ------------------------------------- I wanted to add that the current rationale for having (DML)SemanticAnalyzer handle CREATE TABLE is so that it can easily do CTAS. I think it would be cleaner to handle CTAS as a special case requiring both DDLSemanticAnalyzer and DMLSemanticAnalyzer instead of putting all of the CREATE TABLE logic in the SemanticAnalyzer class. > Extract LogicalPlan and PhysicalPlan classes from SemanticAnalysis class > ------------------------------------------------------------------------ > > Key: HIVE-924 > URL: https://issues.apache.org/jira/browse/HIVE-924 > Project: Hadoop Hive > Issue Type: Bug > Components: Query Processor > Reporter: Carl Steinbach > Attachments: HIVE-924.patch > > > Currently the SemanticAnalyzer class handles semantic analysis, as well as > logical plan generation and physical plan generation. I think it would be > beneficial to extract distinct LogicalPlan and PhysicalPlan classes from the > SemanticAnalyzer, and have the query processing phase be coordinated by a > QueryCompiler class that would be responsible for triggering the parsing, > semantic analysis, logical plan generation, optimization, and physical plan > generation phases. This proposed reorganization of components would help to > isolate the state of each phase, and would also bring the source into closer > alignment with the description of the query compiler in the Hive design > document on the wiki. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.