[ 
https://issues.apache.org/jira/browse/HIVE-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788892#action_12788892
 ] 

Zheng Shao commented on HIVE-924:
---------------------------------

Carl, some notes about our meeting today:

Currently we have:
1. ParseContext: compile-time thing only
2. Operators: contains the desc, the DAG, and the transient variables for 
execution-time only.
3. desc: the description of the operator

I am in favor of an organization like this:
1. CompileTimeOperator: contains information in ParseContext, and desc + DAG.
2. desc + DAG: these are the information that needs to be propagated from 
compile time to execution time. We should put them together and give it a new 
name.
3. Operators: for execution time only, constructed from the desc + DAG.

In this way, only desc+DAG is shared between the compile time and execution 
time and the code can look much cleaner.
Does this look good?


> Extract LogicalPlan and PhysicalPlan classes from SemanticAnalysis class
> ------------------------------------------------------------------------
>
>                 Key: HIVE-924
>                 URL: https://issues.apache.org/jira/browse/HIVE-924
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Carl Steinbach
>         Attachments: HIVE-924.patch
>
>
> Currently the SemanticAnalyzer class handles semantic analysis, as well as 
> logical plan generation and physical plan generation. I think it would be 
> beneficial to extract distinct LogicalPlan and PhysicalPlan classes from the 
> SemanticAnalyzer, and have the query processing phase be coordinated by a 
> QueryCompiler class that would be responsible for triggering the parsing, 
> semantic analysis, logical plan generation, optimization, and physical plan 
> generation phases. This proposed reorganization of components would help to 
> isolate the state of each phase, and would also bring the source into closer 
> alignment with the description of the query compiler in the Hive design 
> document on the wiki.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to