Hi! On Tue, 24 Mar 2009 00:51:46 -0500, "Gabriel M. Beddingfield" <[email protected]> wrote: > Sebastian Moors wrote: >> I've changed that to UTF8 in rev922, but there are plenty of other lines > >> where strings get converted to ascii. > > I've attached a patch that does the following: > > * Replace QString::toAscii() with QString::toLocal8Bit() > > * Replace implicit casts from char* to QString with > QString::fromLocal8Bit(), but only where appropriate. > (e.g. QString foo = "bar" is OK.) > > * Reduce implicit casts between char* and QString > (e.g. qStr == "" and qStr = "") > > Still ought to be done: > > * Specify, verify, handle, or check the encoding of the > XML files that we write. > > I'm sending this as a patch because I just got it to compile... and now > I'm > going to bed without testing it. But, I wanted input from you guys in > case, for > instance, you prefer qStr == "" to qStr.isEmpty().
Wow! Very nice work!! I can't test it here as well (atm), but i've gone through the whole patchset and it looked good. I suppose it won't hurt if you commit it.. - Sebastian > Thanks, > Gabriel ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ Hydrogen-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
