> -----Original Message-----
> From: Intel-gfx <intel-gfx-boun...@lists.freedesktop.org> On Behalf Of Imre 
> Deak
> Sent: Tuesday, 5 August 2025 10.37
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: sta...@vger.kernel.org; Lin, Charlton <charlton....@intel.com>; 
> Almahallawy, Khaled <khaled.almahall...@intel.com>
> Subject: [PATCH 05/19] drm/i915/icl+/tc: Convert AUX powered WARN to a debug 
> message
> 
> The BIOS can leave the AUX power well enabled on an output, even if this 
> isn't required (on platforms where the AUX power is
> only needed for an AUX access). This was observed at least on PTL. To avoid 
> the WARN which would be triggered by this during the
> HW readout, convert the WARN to a debug message.
> 
> Cc: sta...@vger.kernel.org # v6.8+
> Reported-by: Charlton Lin <charlton....@intel.com>
> Tested-by: Khaled Almahallawy <khaled.almahall...@intel.com>

Reviewed-by: Mika Kahola <mika.kah...@intel.com>

> Signed-off-by: Imre Deak <imre.d...@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_tc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c 
> b/drivers/gpu/drm/i915/display/intel_tc.c
> index 14042a64375e1..dec54cb0c8c63 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -1494,11 +1494,11 @@ static void intel_tc_port_reset_mode(struct 
> intel_tc_port *tc,
>       intel_display_power_flush_work(display);
>       if (!intel_tc_cold_requires_aux_pw(dig_port)) {
>               enum intel_display_power_domain aux_domain;
> -             bool aux_powered;
> 
>               aux_domain = intel_aux_power_domain(dig_port);
> -             aux_powered = intel_display_power_is_enabled(display, 
> aux_domain);
> -             drm_WARN_ON(display->drm, aux_powered);
> +             if (intel_display_power_is_enabled(display, aux_domain))
> +                     drm_dbg_kms(display->drm, "Port %s: AUX unexpectedly 
> powered\n",
> +                                 tc->port_name);
>       }
> 
>       tc_phy_disconnect(tc);
> --
> 2.49.1

Reply via email to