> -----Original Message-----
> From: Intel-xe <[email protected]> On Behalf Of Chaitanya
> Kumar Borah
> Sent: Wednesday, June 17, 2026 2:38 PM
> To: [email protected]; [email protected]; intel-
> [email protected]
> Cc: Samala, Pranay <[email protected]>; Borah, Chaitanya Kumar
> <[email protected]>
> Subject: [v3 10/14] drm/i915/color: Extract HDR pre-CSC LUT programming to
> helper function
>
> From: Pranay Samala <[email protected]>
>
> As we prepare to add support for LUT programming in SDR planes, refactor HDR
> plane pre-CSC LUT programming to a helper.
Changes Look Good to me.
Reviewed-by: Uma Shankar <[email protected]>
> Signed-off-by: Pranay Samala <[email protected]>
> Signed-off-by: Chaitanya Kumar Borah <[email protected]>
> ---
> drivers/gpu/drm/i915/display/intel_color.c | 30 ++++++++++++++--------
> 1 file changed, 20 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_color.c
> b/drivers/gpu/drm/i915/display/intel_color.c
> index 87ced9f6ff40..2a32ab62721c 100644
> --- a/drivers/gpu/drm/i915/display/intel_color.c
> +++ b/drivers/gpu/drm/i915/display/intel_color.c
> @@ -3959,20 +3959,15 @@ xelpd_load_plane_csc_matrix(struct intel_dsb *dsb,
> }
>
> static void
> -xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
> - const struct intel_plane_state *plane_state)
> +xelpd_load_hdr_pre_csc_lut(struct intel_display *display,
> + struct intel_dsb *dsb,
> + enum pipe pipe,
> + enum plane_id plane,
> + const struct drm_color_lut32 *pre_csc_lut)
> {
> - struct intel_display *display = to_intel_display(plane_state);
> - const struct drm_plane_state *state = &plane_state->uapi;
> - enum pipe pipe = to_intel_plane(state->plane)->pipe;
> - enum plane_id plane = to_intel_plane(state->plane)->id;
> - const struct drm_color_lut32 *pre_csc_lut = plane_state-
> >hw.degamma_lut->data;
> int i, lut_size = 128;
> u32 lut_val;
>
> - if (!icl_is_hdr_plane(display, plane))
> - return;
> -
> intel_de_write_dsb(display, dsb,
> PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, 0),
> PLANE_PAL_PREC_AUTO_INCREMENT);
> @@ -3997,6 +3992,21 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb
> *dsb,
> intel_de_write_dsb(display, dsb,
> PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, 0), 0); }
>
> +static void
> +xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
> + const struct intel_plane_state *plane_state) {
> + struct intel_display *display = to_intel_display(plane_state);
> + const struct drm_plane_state *state = &plane_state->uapi;
> + enum pipe pipe = to_intel_plane(state->plane)->pipe;
> + enum plane_id plane = to_intel_plane(state->plane)->id;
> + const struct drm_color_lut32 *pre_csc_lut = plane_state-
> >hw.degamma_lut ?
> + plane_state->hw.degamma_lut->data : NULL;
> +
> + if (icl_is_hdr_plane(display, plane))
> + xelpd_load_hdr_pre_csc_lut(display, dsb, pipe, plane,
> pre_csc_lut); }
> +
> static void
> xelpd_program_plane_post_csc_lut(struct intel_dsb *dsb,
> const struct intel_plane_state *plane_state)
> --
> 2.25.1
