Hi Rowan, On Wed, Oct 19, 2016 at 5:14 AM, Rowan Collins <rowan.coll...@gmail.com> wrote: > On 18/10/2016 20:52, Yasuo Ohgaki wrote: >> >> Which is important? >> - uniqid() is not unique >> - Really broken system that shouldn't be used may emit error > > > Frankly, both are pretty rare cases. From the way you talk about it, > everybody who uses uniqid() will get duplicate values all the time, when in > fact, it's incredibly unlikely that anyone will even notice. > > I know when I've used it, it's for things like avoiding duplicate id > attributes on an HTML page, or varying the URL of an asset by adding a token > to the URL. It's perfectly usable as is for those situations, and I use it > with full knowledge that it has a small chance of generating colliding > values. > > I'm happy to see it improved, but I don't see any hurry, unless I'm > completely misunderstanding the chances of seeing collisions.
This is reasonable discussion. I do use uniqid() for HTML id attributes. It is difficult to detect id collisions since it's not server side. (Technically it can, but it requires more resources) While it works almost always, but it should be better than now. Otherwise, I'm very uncomfortable with uniqid(). Regards, -- Yasuo Ohgaki yohg...@ohgaki.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
