On 03/05/2018 07:55 PM, Heldt-Sheller, Nathan wrote:
Hi Phil,
I agree your change has merits and I understand the motive... it was very bad to have the
"reference" .dat files out of sync with their source .json files, and no way
for devs to know. However:
Instead, I recommend adding a specific command that you run after the
tool is run that copies the .dat files from out/ back into the source dir.
This is what I've done,
it's done by default, but it can be done on purpose
I think it should be at the very least an option that can be disabled. E.g. like
"UPDATE_DAT_FILES=0",
yea it can be done, this is trivial in Scan Json function
so that if a dev is changing something that doesn't affect the .json,
json2cbor, or .dat files, but a rebuild changes them, the dev doesn't have to
push the new .dat files.
so .dat will not be modified,
this is the desired behavior...
So let me recap:
1/ .dat files are only used for crossbuilding,
2/ the actual .dat files are generated at build time from json and then
are copied to out/ (and installed on scons install too)
3/ Then they are copied back to sources tree, to see if they differ from
last generation.
The reason you see differences now in master,
is because they were not committed since ACL v2 was introduced,
(this is wrong, but hopefully we don't use them because we're building
out's ones from .json)
So let's just commit them and nobody will be annoyed anymore (in theory),
I can do that, I called sub domains maintainers to check them,
but it can done afterwards (they will do it from json).
Now let me call again everyone to check json files,
1/ update ACL if needed,
2/ rebuild them
3/ and commit .json and .dat pairs in master.
Then if theses files are shown as modified on rebuild, then something
important changed (like Nathan mentioned above)
Hope this is clearer, I can explain more on wiki if needed
Regards
--
mailto:philippe.co...@osg.samsung.com gpg:0x467094BC
https://blogs.s-osg.org/author/pcoval/
_______________________________________________
iotivity-dev mailing list
iotivity-dev@lists.iotivity.org
https://lists.iotivity.org/mailman/listinfo/iotivity-dev
