On Wed, Aug 29, 2018, 7:47 PM Rami Alshafi <rami_in_portl...@hotmail.com> wrote:
> Devs, > > I have extremely simple code review that I submitted 3 weeks ago. It > mainly includes changes in README file, white space modifications (based on > previous code reviews) and fixing a minor issue with the sample app SVR > database. > > Mats has already reviewed it and we went back and forth over 3 separate > patches. I have e-mailed the IoTivity maintainers list and got no response. > > > We really need to improve the efficiency of code reviews and merging code > in order to grow the IoTivity developer community. > > My last patch took more than 7 months to be reviewed and finally merged!! > > Am I alone in this struggle or is this a common problem among developers? > It's a general problem. I submitted an absolutely trivial but critical patch when I got started that languished for months. Thats one reason I no longer bother. With gerrit you have to pick your reviewers, AFAIK. So I'm subscribed to the iotivity list but I'll never know you've submitted a patch if you don't explicitly add me to the reviewer list. You might have better luck notifying the list whenever you submit a patch. You might get lucky! G > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9911): https://lists.iotivity.org/g/iotivity-dev/message/9911 Mute This Topic: https://lists.iotivity.org/mt/25089084/21656 Group Owner: iotivity-dev+ow...@lists.iotivity.org Unsubscribe: https://lists.iotivity.org/g/iotivity-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
