On 09/04/2018 02:46 PM, Gregg Reynolds wrote: > It's a general problem. I submitted an absolutely trivial but critical > patch when I got started that languished for months. Thats one reason I no > longer bother. With gerrit you have to pick your reviewers, AFAIK. So I'm > subscribed to the iotivity list but I'll never know you've submitted a > patch if you don't explicitly add me to the reviewer list. You might have > better luck notifying the list whenever you submit a patch. You might get > lucky!
I bet we could come up with some things to improve that. Thinking out loud, There are groups defined which have a different intent, but could be used to select reviewers a bit more efficiently. See here: https://gerrit.iotivity.org/gerrit/#/admin/groups/ some of those are well set up, some are empty, some you could imagine are not even set up. If the patch affects security, you can select Security Maintainers as a reviewer, and all the members of that group will find out. we're already asked to categorize jira tickets, if Gerrit has that capability, it could ask the same - and then auto-add the relevant group to the reviewers. (I said this is thinking aloud - this might not be an available feature). We could also have a mailing list for all patch activity, so you find out even if you're not flagged for a review, might give a chance to review something that affects you even if the submitter didn't know to put you there. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9912): https://lists.iotivity.org/g/iotivity-dev/message/9912 Mute This Topic: https://lists.iotivity.org/mt/25089084/21656 Group Owner: iotivity-dev+ow...@lists.iotivity.org Unsubscribe: https://lists.iotivity.org/g/iotivity-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
