Thanks Mats. These graphs don't really show the primary contributors recently, though, because those are often (mostly?) working on release branches, not master! It's not as grim as it looks... most of the folks on those graphs have been gone a long time, because work on master was superceded by work on release branches years ago.
That said, yes, we do have some areas that don't have clear owners/maintainers. It's something that is a priority to sort out, and we discussed it on today's OSWG call. I have the action item to follow up with prior ISG (IoTivity Steering Group) members to try to improve. Thanks, Nathan -----Original Message----- From: iotivity-dev@lists.iotivity.org [mailto:iotivity-dev@lists.iotivity.org] On Behalf Of Mats Wichmann Sent: Wednesday, September 5, 2018 11:45 AM To: iotivity-dev@lists.iotivity.org Subject: Re: [dev] Inefficient code reviews On 09/05/2018 11:27 AM, Nash, George wrote: > Typically the best way to find who to add to your reviews is to use "git > blame" find out who else worked on the file you are modifying. These are the > people that know the most about that code. Add them. Many of them are no > longer active but it does not hurt to add them as reviewers. > > Look at who gave +2 approval to the commits made to that file in the past. > Add them. > > Look at https://wiki.iotivity.org/projects_and_functions find out who are the > maintainers for the area of code you are working on. Add them. all of those are great suggestions in general, but only the third one is actually "reliable" across the project at the moment, due to us having lost so many core developers in recent times. If you look at this analysis that github will do for you on the project mirror: https://github.com/iotivity/iotivity/graphs/contributors you'll see that very very few of the people responsible for "most of the code" in the past are still active. I'm not criticising, it's just a reality and we have to be clever in light of that. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9919): https://lists.iotivity.org/g/iotivity-dev/message/9919 Mute This Topic: https://lists.iotivity.org/mt/25089084/21656 Group Owner: iotivity-dev+ow...@lists.iotivity.org Unsubscribe: https://lists.iotivity.org/g/iotivity-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
