Quoting Benoit Guillon <[EMAIL PROTECTED]>:
> Could the new PICMG commands I've sent to the list be included in the
> release too? At least, the small bugs I've seen there should be
> integrated. Just an extract of the sent ipmi_picmg.c patch that fixes
> the small bugs:
>
> @@ -192,11 +194,143 @@
> }
>
> printf("Activation Policy for FRU %x: ", atoi(argv[0]) );
> - printf(" %s\n",(((*(rsp->data+3))&0x01) == 0x01)?"is locked":"is not
> locked");
> + printf("%s, ", (rsp->data[1] & 0x01) ? "is locked" : "is not locked");
> + printf("%s\n", (rsp->data[1] & 0x02) ? "deactivation locked"
> + : "deactivation not locked");
> + return 0;
> +}
>
>
> @@ -608,11 +742,10 @@
> else if (!strncmp(argv[0], "policy", 6)) {
> if (argc > 2) {
> if (!strncmp(argv[1], "get", 3)) {
> - rc = ipmi_picmg_fru_activation_policy_get(intf,
> argc-1, &(argv[2]));
> + rc = ipmi_picmg_fru_activation_policy_get(intf,
> argc-2, &(argv[2]));
> }
>
Hi,
I believe I've already committed the first portion of the patch you
list above as per your 2/8 ipmitool-devel email (it was the #4 on my
list). Please check the cvs tree and make sure it's the way you
wanted it. I've just committed the second part of your patch as well.
Regarding the larger patch you sent earlier, it was also on the list I
put together (#12) and I'll be very happy to do the work to add the
patch. However, generally-speaking, I personally feel uneasy about
adding much code other than bug fixes right before a new release so
I'd feel better if Petter gave the go-ahead on it before I commit it
to 1.8.9. Otherwise, I'll be very happy to add it right after the
release so folks can start using it asap. Petter, what say you? :-)
Thanks very much for all your work to ipmitool even better. :-)
Carol Hebert
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
