Carol Hebert wrote:

>>Did I miss anything?  If not, it appears that maybe all that's left to
>>do to complete the roll to v1.8.9 is to commit the patches for items
>>    
>>
>1-5
>  
>
>>plus Arkadiusz's 1/24 Makefile patch, maybe live with #6 for now and
>>    
>>
>fix
>  
>
>>it in the next release, get more info on #7, and get Steffen's patch
>>(#8) to review for inclusion.  Additionally, maybe consider including
>>some of the patches in items 10, 12, 13, and 14 for 1.8.9 and working
>>    
>>
>to
>  
>
>>get whichever of these patches doesn't make it in and the other
>>outstanding issues fixed in v1.8.10.
>>    
>>
>
>Hi Petter,
>
>Regarding the list from my 2/20/07 email, item #'s 1-5 are now complete.
>Additionally, #'s 9, 10, and 14 have also been completed.  AFAIK, the
>code is ready for final regression testing and release at this time.  It
>appears that Duncan already changed the version number to 1.8.9 too. ;-)
>I've done a few build tests on a couple of different distros and will do
>more regression testing of commands tomorrow.
>
>I believe John Blair (and possibly Steffen as well) may want to submit a
>final patch for inclusion in 1.8.9.  I'd like to propose that we freeze
>the cvs tree within a day or two to give folks time to submit any ready
>and tested patches?  Anyone second this proposal?
>
>Thanks again for all your help,
>  
>
Could the new PICMG commands I've sent to the list be included in the 
release too? At least, the small bugs I've seen there should be 
integrated. Just an extract of the sent ipmi_picmg.c patch that fixes 
the small bugs:

@@ -192,11 +194,143 @@
        }
 
        printf("Activation Policy for FRU %x: ", atoi(argv[0]) );
-       printf(" %s\n",(((*(rsp->data+3))&0x01) == 0x01)?"is locked":"is not 
locked");
+       printf("%s, ", (rsp->data[1] & 0x01) ? "is locked" : "is not locked");
+       printf("%s\n", (rsp->data[1] & 0x02) ? "deactivation locked"
+                                       : "deactivation not locked");
+       return 0;
+}


@@ -608,11 +742,10 @@
        else if (!strncmp(argv[0], "policy", 6)) {
                if (argc > 2) {
                        if (!strncmp(argv[1], "get", 3)) {
-                               rc = ipmi_picmg_fru_activation_policy_get(intf, 
argc-1, &(argv[2]));
+                               rc = ipmi_picmg_fru_activation_policy_get(intf, 
argc-2, &(argv[2]));
                        }

Thanks,

-- 
BenoƮt Guillon                [EMAIL PROTECTED]
TCT/3S                        tel. : 33 (0)4 98 16 33 90
 
THALES COMPUTERS


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel

Reply via email to