[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029677#comment-16029677
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1304#discussion_r119149908
  
    --- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/UUIDTimer.java 
---
    @@ -293,6 +293,7 @@ private static void slowDown(final long startTime, 
final long actDiff) {
              if (++counter > UUIDTimer.MAX_WAIT_COUNT) {
                 break;
              }
    -      } while (System.currentTimeMillis() < waitUntil);
    +      }
    --- End diff --
    
    actually, this should be on the same line....:/
    
    
    there was a discussion an year ago more or less... I think @cshannon was 
part of it...


> Fix checkstyle violations post checkstyle  upgrade
> --------------------------------------------------
>
>                 Key: ARTEMIS-1189
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to