[
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029681#comment-16029681
]
ASF GitHub Bot commented on ARTEMIS-1189:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1304#discussion_r119150371
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
---
@@ -175,7 +176,8 @@ private void piggyBackResponses(ByteBuf buf) {
} catch (InterruptedException e) {
break;
}
- } while (responses.isEmpty());
+ }
--- End diff --
it seems thats the upstream change, that came in 7.
> Fix checkstyle violations post checkstyle upgrade
> --------------------------------------------------
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce
> future pain.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
