[ https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029799#comment-16029799 ]
ASF GitHub Bot commented on ARTEMIS-1189: ----------------------------------------- Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1304#discussion_r119166058 --- Diff: etc/checkstyle.xml --- @@ -73,7 +71,7 @@ under the License. <module name="RightCurly"/> <module name="RightCurly"> <property name="option" value="alone"/> - <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, STATIC_INIT, INSTANCE_INIT"/> + <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/> --- End diff -- It seems we can add <module name="RightCurly"> <property name="option" value="same"/> <property name="tokens" value="LITERAL_DO"/> </module> to keep the old format of a do while, with the while on same line, and have it checked by check style , i assume this is what you'd like > Fix checkstyle violations post checkstyle upgrade > -------------------------------------------------- > > Key: ARTEMIS-1189 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1189 > Project: ActiveMQ Artemis > Issue Type: Bug > Reporter: Michael Andre Pearce > > After upgrading check style as part of resolving ARTEMIS-1188, > Checkstyle has bug fixes, which has meant it has picked up check style errors > that it should have previously. > A temporary fix was to make check style ignore these, as already present. > We should remove this override, and fix the check style violations. To reduce > future pain. -- This message was sent by Atlassian JIRA (v6.3.15#6346)