[
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029698#comment-16029698
]
ASF GitHub Bot commented on ARTEMIS-1189:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1304#discussion_r119152397
--- Diff: etc/checkstyle.xml ---
@@ -46,9 +46,7 @@ under the License.
<!-- Modifier Checks -->
<module name="ModifierOrder"/>
- <module name="RedundantModifier">
- <property name="tokens" value="ANNOTATION_FIELD_DEF,
INTERFACE_DEF, CLASS_DEF, ENUM_DEF"/>
- </module>
+ <module name="RedundantModifier"/>
--- End diff --
+1
> Fix checkstyle violations post checkstyle upgrade
> --------------------------------------------------
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce
> future pain.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
