[
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029779#comment-16029779
]
ASF GitHub Bot commented on ARTEMIS-1189:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1304#discussion_r119161883
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
<module name="RightCurly"/>
<module name="RightCurly">
<property name="option" value="alone"/>
- <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF,
LITERAL_FOR, LITERAL_WHILE, STATIC_INIT, INSTANCE_INIT"/>
+ <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF,
LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
--- End diff --
yes so this change is putting back the config to what we had before (but
then we have to fix the while do's as on latest / >7 check style it enforces
the while to a new line.
> Fix checkstyle violations post checkstyle upgrade
> --------------------------------------------------
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce
> future pain.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
