[
https://issues.apache.org/jira/browse/ARTEMIS-2662?focusedWorklogId=404551&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404551
]
ASF GitHub Bot logged work on ARTEMIS-2662:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/20 08:57
Start Date: 17/Mar/20 08:57
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #3021: ARTEMIS-2662
Using previously stored encodeSize on page record offset
URL: https://github.com/apache/activemq-artemis/pull/3021#discussion_r393527033
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/paging/AmqpPageReaderTest.java
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.integration.amqp.paging;
+
+import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
+import org.apache.activemq.artemis.api.core.ActiveMQBuffers;
+import org.apache.activemq.artemis.api.core.Message;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.paging.cursor.impl.PageReaderTest;
+import org.apache.activemq.artemis.protocol.amqp.broker.AMQPStandardMessage;
+import org.apache.activemq.artemis.spi.core.protocol.MessagePersister;
+import org.apache.activemq.artemis.tests.integration.amqp.AmqpTestSupport;
+import org.apache.activemq.transport.amqp.client.AmqpMessage;
+import org.apache.qpid.proton.message.impl.MessageImpl;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class AmqpPageReaderTest extends PageReaderTest {
+
+ public MessageImpl createProtonMessage(String address) {
+ AmqpMessage message = new AmqpMessage();
+ final StringBuilder builder = new StringBuilder();
+ for (int i = 0; i < 1000; i++) {
+ builder.append('0');
+ }
+ final String data = builder.toString();
+ message.setText(data);
+ message.setAddress(address);
+ message.setDurable(true);
+
+ MessageImpl protonMessage = (MessageImpl) message.getWrappedMessage();
+
+ return protonMessage;
+ }
+
+ @Override
+ protected Message createMessage(SimpleString address, int msgId, byte[]
content) {
+ MessageImpl protonMessage = createProtonMessage(address.toString());
+ AMQPStandardMessage amqpStandardMessage =
AmqpTestSupport.encodeAndDecodeMessage(0, protonMessage, 2 * 1024);
+ amqpStandardMessage.setMessageID(msgId);
+
+ return amqpStandardMessage;
+ }
+
+
+ @Test
+ public void testEncodeSize() throws Exception {
+
+ Message message = createMessage(SimpleString.toSimpleString("Test"), 1,
new byte[10]);
+
+ MessagePersister persister = (MessagePersister)message.getPersister();
+
+ ActiveMQBuffer buffer = ActiveMQBuffers.dynamicBuffer(1024);
+ persister.encode(buffer, message);
+
+ Assert.assertEquals(persister.getEncodeSize(message),
buffer.writerIndex());
+
+ // the very first byte is the persisterID, we skip that since we are
calling the Persister directly
+ buffer.readerIndex(1);
+ Message messageRead = persister.decode(buffer, null, null);
+
+ // The current persister does not guarantee the same encode size after
loading
+ // and it does not need to
+ // Assert.assertEquals(persister.getEncodeSize(message),
persister.getEncodeSize(messageRead));
Review comment:
This test class should be cleaned up a bit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 404551)
Time Spent: 0.5h (was: 20m)
> Page is broken for AMQP if readWholePage=true
> ---------------------------------------------
>
> Key: ARTEMIS-2662
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2662
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.10.0, 2.10.1
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
