[ 
https://issues.apache.org/jira/browse/ARTEMIS-2662?focusedWorklogId=404565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404565
 ]

ASF GitHub Bot logged work on ARTEMIS-2662:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Mar/20 09:29
            Start Date: 17/Mar/20 09:29
    Worklog Time Spent: 10m 
      Work Description: franz1981 commented on pull request #3021: ARTEMIS-2662 
Using previously stored encodeSize on page record offset
URL: https://github.com/apache/activemq-artemis/pull/3021#discussion_r393545064
 
 

 ##########
 File path: 
artemis-server/src/test/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageReaderTest.java
 ##########
 @@ -58,7 +58,7 @@ public void testPageReadMessage() throws Exception {
             PagePosition pagePosition = new PagePositionImpl(10, i);
             pagedMessage = pageReader.getMessage(pagePosition);
          } else {
-            int nextFileOffset = pagedMessage == null ? -1 : offsets[i - 1] + 
pagedMessage.getEncodeSize() + Page.SIZE_RECORD;
+            int nextFileOffset = pagedMessage == null ? -1 : offsets[i - 1] + 
pagedMessage.getStoredSize() + Page.SIZE_RECORD;
 
 Review comment:
   I don't know why, but my IDEA isn't happy with this test, see
   
![image](https://user-images.githubusercontent.com/13125299/76842129-1486ec80-683a-11ea-8c10-3d48418c9bdf.png)
   Although I can run it and it compiles correctly...:(
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 404565)
    Time Spent: 1h  (was: 50m)

> Page is broken for AMQP if readWholePage=true
> ---------------------------------------------
>
>                 Key: ARTEMIS-2662
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2662
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.10.0, 2.10.1
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>            Priority: Major
>             Fix For: 2.11.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to